05-13-2018, 05:15 PM
I sent a pull request with most of the fixes. I didn't touch the instruments where you're going to edit or rename samples. I'll wait till you have those done, then make any needed changes.
It works fine for me. What kind of stuttering are you getting? I don't see how offsets could cause that.
I believe it's correct. I compared it to a couple of other instruments, and even plotted the spectrum for one note to be sure I wasn't mishearing it. This is just a really high pitched instrument.
These were... interesting... to do. I was able to get the autotuning to work reasonably well by telling it to ignore the first 0.1 seconds of each sample. The very highest and lowest notes tend to get kind of indefinite, though, so I had to tune some of those by hand.
The samples Mbira5_Normal_MainSpirit_A#1_k12_vl2_rr1.wav and Mbira5_Normal_MainSpirit_C2_k10_vl2_rr1.wav sound to me like they're exactly the same note, but the pitch is so vague that it's hard to say exactly what note it is. I ended up telling it to treat the "A#1" sample as actually being B1.
Quote:The offsets in Gong2 seem incorrect and cause very strange stuttering behavior in ARIA.
It works fine for me. What kind of stuttering are you getting? I don't see how offsets could cause that.
Quote:Tubular Glockenspiel is at least one octave too high.
I believe it's correct. I compared it to a couple of other instruments, and even plotted the spectrum for one note to be sure I wasn't mishearing it. This is just a really high pitched instrument.
Quote:It's may even have to be manually done, but the Plucked Idiophones will need to be tuned.
These were... interesting... to do. I was able to get the autotuning to work reasonably well by telling it to ignore the first 0.1 seconds of each sample. The very highest and lowest notes tend to get kind of indefinite, though, so I had to tune some of those by hand.
The samples Mbira5_Normal_MainSpirit_A#1_k12_vl2_rr1.wav and Mbira5_Normal_MainSpirit_C2_k10_vl2_rr1.wav sound to me like they're exactly the same note, but the pitch is so vague that it's hard to say exactly what note it is. I ended up telling it to treat the "A#1" sample as actually being B1.