Peter, I just checked out the latest versions. Some really great stuff, especially with some good reverb added! The saxes and harmonicas are an absolute joy to play.
I found a few things-
- The Dan Tranh was not relabeled right or perhaps needs some serious tuning adjustments. The B's are all an octave too high. It also cuts off notes on release when it should sustain openly.
- Some of the strumstick notes are quite out of tune (e.g. Strumstick_Finger_Str2_Main_D3_vl3_rr1.wav). Not sure if you can fix this on your end; I thought I had the samples tuned.
- The pianos sound much more realistic with a release of 0.4 (I have gone ahead and made this change).
- Starting on E6 (C3=60) and up, there are no more releases on the piano and all keys should be given a long release of something like 10.0. This *can* be done by hand, but might be better to add to the script, since it is a feature of virtually all modern pianos.
- It appears Steinway B is actually C4=60. I don't know why or how (I swear I thought it was C3=60), but it is.
- It is HIGHLY suggested that Steinway B should not be tuned. In fact, if you want to tune a piano, you should apply exactly identical tuning across all samples of the same note name (e.g. all the E6 samples should be offset together by the same amount with tune=). The best place to decide this offset from would be the middle velocity layer, or in absence, the lowest velocity layer. As the piano is hit harder, the first few waves after the hit of the hammer may appear to be at a higher pitch. This fools digital tuners into thinking the louder notes are sharp, when after half a second they fall down to the pitch they *actually* have. The same issue occurs on all harps, guitars, and other plucked instruments (including the plucked psaltery) which have dynamics, so this may be part of that strumstick tuning issue if there's any tuning on that.
- There is an errant extra RR in the English Harpsichord on A#4 in the Lute patch. I'll remove this sample in the main branch. There are also a few notes which have odd resonances which I will need to check (e.g. F#3) in the same. I also don't think the tuning belongs on the English Harpsichord (or any other harpsichord), it sounds out of tune. All of the harpsichords should be perfectly pre-tuned. The number of instruments which aren't pre-tuned and need tuning scripted in should actually be quite low, since it's a standard part of the process for cutting most of them. The only generalized exception is lamellophones like the mbiras and kalimbas, which don't comply to western tunings.
- For clarity, it might be best to rename 'Harpsichord, Flemish - High' to 'Harpsichord, Flemish - 4' ' and "Low" to "8' ".
- It's may even have to be manually done, but the Plucked Idiophones will need to be tuned.
- The tuning in Bell Tree - Individual (D5 +33c) was incorrect, so I commented it out.
- Having a tight release on Claps made no sense, so I made it 2.0.
- The offsets in Gong2 seem incorrect and cause very strange stuttering behavior in ARIA.
- Note to self: too much background noise in Siren and Shaker, Small, fix weird noise in Tamb2 Shake rr3.
- Tamb1_Shake_rr1_Mid can be have even more cut off the front. I think I will instead just go and edit the sample itself.
- Tambourine 4 - Legacy's "tamb2_rr1" is louder than the other 3rr. It might be better if we rename/re-purpose it as an upper velocity layer.
- Tubular Bells 2 are an octave too high (i.e. they're C4=60).
- Tubular Glockenspiel is at least one octave too high.
- Definitely do not tune the mallets (xylo, marimba, glock, vibes, tubular bells, etc.) as these all have fixed pitch at time of creation and do not really change pitch over time unless horribly broken.
- Xylophone is one octave too high (i.e. C4=60). It's one of those older instruments...
- Changed release of Ocean Drum to 4.0. In reality, the darned things are almost impossible to stop, haha.
- Bass Drum 3 appears to be a little too loud, I managed to make it clip. Maybe knock 2 dB off on average.
- Legacy Snares all appear quiet. Suggest adding 6 dB.
- Timpani1 appears an octave too low, but it sounds fantastic.
- Attack of 0.1 on soprano recorder sounds unrealistic (the instrument is supposed to have that chiffy start), so I removed it.
- Technically the organs should all have no velocity-sensitive dynamics, instead they use typically some form of swell shutter.
The Hi-Hat should follow the GM map spec-
http://computermusicresource.com/GM.Perc...eyMap.html
Close=44
HitC=42
HitO=46
HitLoose & HitOC can probably be mapped to 43 and 45 then, at least for now, although they don't have an official home in the GM spec.
Similarly Suspended Cymbal 'hit' could possibly go on the note for Crash Cymbal and 'hit_stick' can go on the note for Ride Cymbal, with Bell on the Crash Cymbal 2 spot or whatever... or we can just leave it as is (although it would be better if we eventually moved the hits to the bottom of the range and put the effects higher up; that's a typical mapping configuration). Right now the percussion are sort of mapped wherever (I think they were mapped just alphabetically?), so that'll need to be fixed at some point so they have a more logical and coherent order. Likewise we'll need to come up with a plan for snares. Generally I try to put the most common/important notes on the white keys, but I'm open to ideas to try to make it more easy to map with the script.
Edit- just pushed my sfz changes to the sfz branch. Will see about sample edits tomorrow or the day after as time permits.